Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for preceding and ordering document refs #38

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Adding support for preceding and ordering document refs #38

merged 3 commits into from
Oct 14, 2024

Conversation

samlown
Copy link
Contributor

@samlown samlown commented Oct 9, 2024

No description provided.

@samlown samlown requested a review from cavalle October 9, 2024 11:17
cavalle
cavalle approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just noticed the new structs are in English and the old ones still in Italian, but I understand we're transitioning to english only

@samlown
Copy link
Contributor Author

samlown commented Oct 9, 2024

LGTM! I just noticed the new structs are in English and the old ones still in Italian, but I understand we're transitioning to english only

Correct. I didn't want to move them all in one go, but for new stuff it makes sense.

@samlown samlown merged commit f4d4ead into main Oct 14, 2024
4 checks passed
@samlown samlown deleted the ordering-doc-refs branch October 14, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavalle cavalle cavalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlown @cavalle